On 15/12/2020 01:00, Dave Chinner wrote: > On Tue, Dec 15, 2020 at 12:20:24AM +0000, Pavel Begunkov wrote: >> A preparation patch. It adds a simple helper which abstracts out number >> of segments we're allocating for a bio from iov_iter_npages(). > > Preparation for what? bio_iov_vecs_to_alloc() doesn't seem to be > used outside this specific patch, so it's not clear what it's > actually needed for... Yes, it's not used, but modified in [6/6]. It's here to generilise these bits of iomap and block dio, so we can change the behaviour in one place. -- Pavel Begunkov