Hey Mark, > In the head.S code, this was under an ifdef CONFIG_ARM_GIC_V3, but that > ifdef wasn't carried into the macro here, or into its use below. I'm not > sure of the impact, but that does seem to be a functional change. > > > + > > +.macro __init_el2_hstr > > + msr hstr_el2, xzr // Disable CP15 traps to EL2 > > +.endm > > Likewise, this used to be be guarded by CONFIG_COMPAT, but that's not > carried into the macro or its use. > > If the intent was to remove the conditionality, then that should be > mentioned in the commit message, since it is a potential functional > change. Apologies, and well spotted. Marc suggested removing the ifdefs as redundant during his review of v2. I'll update the commit message to reflect that. David
