Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Iurii Zaikin <yzaikin@xxxxxxxxxx>
Subject: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
From: Alan Maguire <alan.maguire@xxxxxxxxxx>
Date: Wed, 4 Dec 2019 15:30:46 +0000 (GMT)
Cc: Alan Maguire <alan.maguire@xxxxxxxxxx>, Brendan Higgins <brendanhiggins@xxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, KUnit Development <kunit-dev@xxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, catalin.marinas@xxxxxxx, joe.lawrence@xxxxxxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, urezki@xxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, corbet@xxxxxxx, David Gow <davidgow@xxxxxxxxxx>, adilger.kernel@xxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, Luis Chamberlain <mcgrof@xxxxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, Knut Omang <knut.omang@xxxxxxxxxx>
In-reply-to: <CAAXuY3rYZHac4o1bqqnbR_1g12dtqmJHVp8Taky00J4-+2hwZA@mail.gmail.com>
References: <1575374868-32601-1-git-send-email-alan.maguire@oracle.com> <1575374868-32601-4-git-send-email-alan.maguire@oracle.com> <CAAXuY3rYZHac4o1bqqnbR_1g12dtqmJHVp8Taky00J4-+2hwZA@mail.gmail.com>
User-agent: Alpine 2.20 (LRH 67 2015-01-07)

On Tue, 3 Dec 2019, Iurii Zaikin wrote:

> > +ifeq ($(CONFIG_EXT4_KUNIT_TESTS),y)
> >  ext4-$(CONFIG_EXT4_KUNIT_TESTS)                += inode-test.o
> > +else
> > +obj-$(CONFIG_EXT4_KUNIT_TESTS)         += ext4-inode-test.o
> > +ext4-inode-test-objs                   += inode-test.o
> > +endif
> Why not rename it unconditionally?
> 

Good point - I've fixed this in v6. Thanks for the review!

Alan

References:
- [PATCH v5 linux-kselftest-test 0/6] kunit: support building core/tests as modules
  - From: Alan Maguire
- [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
  - From: Alan Maguire
- Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
  - From: Iurii Zaikin

Prev by Date: [PATCH v6 linux-kselftest-test 6/6] kunit: update documentation to describe module-based build
Next by Date: [PATCH v6 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Previous by thread: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Next by thread: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]