Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alan Maguire <alan.maguire@xxxxxxxxxx>
Subject: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
From: Iurii Zaikin <yzaikin@xxxxxxxxxx>
Date: Tue, 3 Dec 2019 16:17:07 -0800
Cc: Brendan Higgins <brendanhiggins@xxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, KUnit Development <kunit-dev@xxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, akpm@xxxxxxxxxxxxxxxxxxxx, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>, catalin.marinas@xxxxxxx, joe.lawrence@xxxxxxxxxx, penguin-kernel@xxxxxxxxxxxxxxxxxxx, urezki@xxxxxxxxx, andriy.shevchenko@xxxxxxxxxxxxxxx, corbet@xxxxxxx, David Gow <davidgow@xxxxxxxxxx>, adilger.kernel@xxxxxxxxx, "Theodore Ts'o" <tytso@xxxxxxx>, Luis Chamberlain <mcgrof@xxxxxxxxxx>, "open list:DOCUMENTATION" <linux-doc@xxxxxxxxxxxxxxx>, Knut Omang <knut.omang@xxxxxxxxxx>
In-reply-to: <1575374868-32601-4-git-send-email-alan.maguire@oracle.com>
References: <1575374868-32601-1-git-send-email-alan.maguire@oracle.com> <1575374868-32601-4-git-send-email-alan.maguire@oracle.com>

> +ifeq ($(CONFIG_EXT4_KUNIT_TESTS),y)
>  ext4-$(CONFIG_EXT4_KUNIT_TESTS)                += inode-test.o
> +else
> +obj-$(CONFIG_EXT4_KUNIT_TESTS)         += ext4-inode-test.o
> +ext4-inode-test-objs                   += inode-test.o
> +endif
Why not rename it unconditionally?

Follow-Ups:
- Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
  - From: Alan Maguire

References:
- [PATCH v5 linux-kselftest-test 0/6] kunit: support building core/tests as modules
  - From: Alan Maguire
- [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
  - From: Alan Maguire

Prev by Date: Re: [PATCH 3/8] fscrypt: Change format of no-key token
Next by Date: Re: [PATCH 4/8] vfs: Fold casefolding into vfs
Previous by thread: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Next by thread: Re: [PATCH v5 linux-kselftest-test 3/6] kunit: allow kunit tests to be loaded as a module
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]