> From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck > Sent: Monday, November 11, 2019 8:45 PM > To: Tremblay, Eric <etremblay@xxxxxxxxxxxxxxxxxxxx>; linux-hwmon@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > doc@xxxxxxxxxxxxxxx > Cc: jdelvare@xxxxxxxx; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; corbet@xxxxxxx > Subject: Re: [PATCH v7 1/2] dt-bindings: hwmon: Add TMP512/513 > > On 11/11/19 12:34 PM, etremblay@xxxxxxxxxxxxxxxxxxxx wrote: > > From: Eric Tremblay <etremblay@xxxxxxxxxxxxxxxxxxxx> > > > > Document the TMP513/512 device devicetree bindings > > > > Signed-off-by: Eric Tremblay <etremblay@xxxxxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/hwmon/ti,tmp513.yaml | 89 +++++++++++++++++++ > > 1 file changed, 89 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > > > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > > b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > > new file mode 100644 > > index 000000000000..de4ed3645e0f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp513.yaml > > @@ -0,0 +1,89 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2 > > +--- > > + > > +$id: > > +https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_sc > > +hemas_hwmon_ti-2Ctmp513.yaml-23&d=DwICaQ&c=tvvHx3uC0XdtgG-ImPDjfM0Qna > > +kIsmmGcwejQDVxD-g&r=y34zLl9_AvBy5NSrvskG6SFbiKoCzI99WW2xhKlsVV4&m=d33 > > +wBKig7BZ0kss0OOUmmNbl5HWsWnMBDtfFv5-rsXo&s=KeOmfQeqUEi1WkJCgcjnWTIIsS > > +kzY2hiRajIVVkq-lc&e= > > +$schema: > > +https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_me > > +ta-2Dschemas_core.yaml-23&d=DwICaQ&c=tvvHx3uC0XdtgG-ImPDjfM0QnakIsmmG > > +cwejQDVxD-g&r=y34zLl9_AvBy5NSrvskG6SFbiKoCzI99WW2xhKlsVV4&m=d33wBKig7 > > +BZ0kss0OOUmmNbl5HWsWnMBDtfFv5-rsXo&s=Nel6OcDfyv8xWX3hGYbELKfEo9XLEwL7 > > +lVrzLKHcB6E&e= > > + > > +title: TMP513/512 system monitor sensor > > + > > +maintainers: > > + - Eric Tremblay <etremblay@xxxxxxxxxxxxxxxxxxxx> > > + > > +description: | > > + This driver implements support for Texas Instruments TMP512, and TMP513. > > I think this needs some rewording. This is not a driver description, but a system description. Ok, I will only keep the chip description. > > > + The TMP512 (dual-channel) and TMP513 (triple-channel) are system > > + monitors that include remote sensors, a local temperature sensor, > > + and a high-side current shunt monitor. These system monitors have > > + the capability of measuring remote temperatures, on-chip > > + temperatures, and system voltage/power/current consumption. > > + > > + Datasheets: > > + > > + https://urldefense.proofpoint.com/v2/url?u=http-3A__www.ti.com_lit_g > > + pn_tmp513&d=DwICaQ&c=tvvHx3uC0XdtgG-ImPDjfM0QnakIsmmGcwejQDVxD-g&r=y > > + 34zLl9_AvBy5NSrvskG6SFbiKoCzI99WW2xhKlsVV4&m=d33wBKig7BZ0kss0OOUmmNb > > + l5HWsWnMBDtfFv5-rsXo&s=7QkDr8n0JXPVmCGRf6jhQPK9h4ECRFMfZJrqttVxWG8&e > > + = > > + https://urldefense.proofpoint.com/v2/url?u=http-3A__www.ti.com_lit_g > > + pn_tmp512&d=DwICaQ&c=tvvHx3uC0XdtgG-ImPDjfM0QnakIsmmGcwejQDVxD-g&r=y > > + 34zLl9_AvBy5NSrvskG6SFbiKoCzI99WW2xhKlsVV4&m=d33wBKig7BZ0kss0OOUmmNb > > + l5HWsWnMBDtfFv5-rsXo&s=2c47z9hddR3vxWAytRxK08SO939Tsi12ePH1uGK_oII&e > > + = > > + > > + > > +properties: > > + compatible: > > + enum: > > + - ti,tmp512 > > + - ti,tmp513 > > + > > + reg: > > + maxItems: 1 > > + > > + shunt-resistor-micro-ohms: > > + description: | > > + If 0, the calibration process will be skiped and the current and power > > + measurement engine will not work. Temperature and voltage measurement > > + will continue to work. The shunt value also need to respect: > > + rshunt <= pga-gain * 40 * 1000 * 1000. > > + If not, it's not possible to compute a valid calibration value. > > + default: 1000 > > + > > + ti,pga-gain: > > + description: | > > + The gain value for the PGA function. This is 8, 4, 2 or 1. > > + The PGA gain affect the shunt voltage range. > > + The range will be equal to: pga-gain * 40mV > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 4, 8] > > + default: 8 > > + > > + ti,bus-range-microvolt: > > + description: | > > + This is the operating range of the bus voltage in microvolt > > + allOf: > > + - $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [16000000, 32000000] > > + default: 32000000 > > + > > + ti,nfactor: > > + description: | > > + Array of three(TMP513) or two(TMP512) n-Factor value for each remote > > + temperature channel. > > + See datasheet Table 11 for n-Factor range list and value interpretation. > > + allOf: > > + - $ref: /schemas/types.yaml#definitions/uint8-array > > + - minItems: 2 > > + maxItems: 3 > > + items: > > + default: 0 > > + > > +required: > > + - compatible > > + - reg > > + > > +examples: > > + - | > > + i2c { > > + tmp513@5c { > > + compatible = "ti,tmp513"; > > + reg = <0x5C>; > > + shunt-resistor-micro-ohms = <330000>; > > + ti,bus-range-microvolt = <32000000>; > > + ti,pga-gain = <8>; > > + ti,nfactor = [01 F3 00]; > > + }; > > + }; > >
