On Thu, Oct 17, 2019 at 11:08 AM Alan Maguire <alan.maguire@xxxxxxxxxx> wrote: > > also remove unused kunit_generic_try_catch > > Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx> Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx> > --- > include/kunit/try-catch.h | 10 ---------- > lib/kunit/test-test.c | 1 + > lib/kunit/test.c | 1 + > lib/kunit/try-catch-impl.h | 23 +++++++++++++++++++++++ Just wanted to say that I *am* happy with the *-impl.h naming scheme here since there is a public header file with almost the same name. So everything looks good to me with this patch. > lib/kunit/try-catch.c | 1 + > 5 files changed, 26 insertions(+), 10 deletions(-) > create mode 100644 lib/kunit/try-catch-impl.h Thanks for the patch!