also remove unused kunit_generic_try_catch Signed-off-by: Alan Maguire <alan.maguire@xxxxxxxxxx> --- include/kunit/try-catch.h | 10 ---------- lib/kunit/test-test.c | 1 + lib/kunit/test.c | 1 + lib/kunit/try-catch-impl.h | 23 +++++++++++++++++++++++ lib/kunit/try-catch.c | 1 + 5 files changed, 26 insertions(+), 10 deletions(-) create mode 100644 lib/kunit/try-catch-impl.h diff --git a/include/kunit/try-catch.h b/include/kunit/try-catch.h index 404f336..c507dd4 100644 --- a/include/kunit/try-catch.h +++ b/include/kunit/try-catch.h @@ -53,11 +53,6 @@ struct kunit_try_catch { void *context; }; -void kunit_try_catch_init(struct kunit_try_catch *try_catch, - struct kunit *test, - kunit_try_catch_func_t try, - kunit_try_catch_func_t catch); - void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context); void __noreturn kunit_try_catch_throw(struct kunit_try_catch *try_catch); @@ -67,9 +62,4 @@ static inline int kunit_try_catch_get_result(struct kunit_try_catch *try_catch) return try_catch->try_result; } -/* - * Exposed for testing only. - */ -void kunit_generic_try_catch_init(struct kunit_try_catch *try_catch); - #endif /* _KUNIT_TRY_CATCH_H */ diff --git a/lib/kunit/test-test.c b/lib/kunit/test-test.c index 5ebe059..c4162a9 100644 --- a/lib/kunit/test-test.c +++ b/lib/kunit/test-test.c @@ -6,6 +6,7 @@ * Author: Brendan Higgins <brendanhiggins@xxxxxxxxxx> */ #include <kunit/test.h> +#include "try-catch-impl.h" struct kunit_try_catch_test_context { struct kunit_try_catch *try_catch; diff --git a/lib/kunit/test.c b/lib/kunit/test.c index 017d4fb..49ac5fe 100644 --- a/lib/kunit/test.c +++ b/lib/kunit/test.c @@ -11,6 +11,7 @@ #include <linux/kernel.h> #include <linux/sched/debug.h> #include "string-stream-impl.h" +#include "try-catch-impl.h" static void kunit_set_failure(struct kunit *test) { diff --git a/lib/kunit/try-catch-impl.h b/lib/kunit/try-catch-impl.h new file mode 100644 index 0000000..aa11e46 --- /dev/null +++ b/lib/kunit/try-catch-impl.h @@ -0,0 +1,23 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * An API to allow a function, that may fail, to be executed, and recover in a + * controlled manner. + * + * Copyright (C) 2019, Google LLC. + * Author: Brendan Higgins <brendanhiggins@xxxxxxxxxx> + */ + +#ifndef _KUNIT_TRY_CATCH_IMPL_H +#define _KUNIT_TRY_CATCH_IMPL_H + +#include <kunit/try-catch.h> +#include <linux/types.h> + +struct kunit; + +void kunit_try_catch_init(struct kunit_try_catch *try_catch, + struct kunit *test, + kunit_try_catch_func_t try, + kunit_try_catch_func_t catch); + +#endif /* _KUNIT_TRY_CATCH_IMPL_H */ diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c index 55686839..0c4c90c 100644 --- a/lib/kunit/try-catch.c +++ b/lib/kunit/try-catch.c @@ -13,6 +13,7 @@ #include <linux/kernel.h> #include <linux/kthread.h> #include <linux/sched/sysctl.h> +#include "try-catch-impl.h" void __noreturn kunit_try_catch_throw(struct kunit_try_catch *try_catch) { -- 1.8.3.1