Re: [PATCH v2 03/12] drm/ast: Move cursor update code to ast_show_cursor()

[Gerd Hoffmann <kraxel@xxxxxxxxxx>]

  Hi,

> -static void ast_hide_cursor(struct drm_crtc *crtc)
> -{
> -	struct ast_private *ast = crtc->dev->dev_private;
> -	ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xcb, 0xfc, 0x00);
> -}

> +static void ast_hide_cursor(struct drm_crtc *crtc)
> +{
> +	struct ast_private *ast = crtc->dev->dev_private;
> +
> +	ast_set_index_reg_mask(ast, AST_IO_CRTC_PORT, 0xcb, 0xfc, 0x00);
> +}

Please split this into two patches, one which only moves the functions
and one which does the code changes.  Then it is easier to see the
actual code changes for ast_{show,hide}_cursor in the diff output of the
second patch.

cheers,
  Gerd