On Fri, 2019-09-06 at 08:34 -0300, Mauro Carvalho Chehab wrote: > I did some changes on it, plus one change at the pedantic mode of > scripts/spdxcheck.py, and placed the corresponding patches at: > > https://git.linuxtv.org/mchehab/experimental.git/log/?h=spdx_pedantic Overall seems very nice, thanks. Couple nits. Some of the scripts and py files move the author block into a description or add unnecessary blank comments. These may use some manual fixups. For instance: diff --git a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh index f12a4e2..ff610ec 100755 --- a/tools/perf/tests/shell/record+probe_libc_inet_pton.sh +++ b/tools/perf/tests/shell/record+probe_libc_inet_pton.sh @@ -1,4 +1,5 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0 # probe libc's inet_pton & backtrace it with ping # Installs a probe on libc's inet_pton function, that will use uprobes, @@ -6,8 +7,6 @@ # with the a backtrace 3 levels deep, check that it is what we expect. # This needs no debuginfo package, all is done using the libc ELF symtab # and the CFI info in the binaries. - -# SPDX-License-Identifier: GPL-2.0 # Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, 2017 . $(dirname $0)/lib/probe.sh and diff --git a/tools/testing/selftests/bpf/tcp_client.py b/tools/testing/selftests/bpf/tcp_client.py index a53ed58..c2ee17d 100755 --- a/tools/testing/selftests/bpf/tcp_client.py +++ b/tools/testing/selftests/bpf/tcp_client.py @@ -1,7 +1,7 @@ #!/usr/bin/env python3 -# # SPDX-License-Identifier: GPL-2.0 # +# > what's the "very first line" where a > SPDX header tag should be on a man page? Beats me. This says man pages are documents, https://spdx.org/rdf/ontology/spdx-2-0-rev-7/individuals/usageType_document___85292652.html
