On Tue, Feb 26, 2019 at 12:49 PM Denis Efremov <efremov@xxxxxxxxx> wrote: > Recent "New LSM Hooks" discussion has led me to the > thought that it might be a good idea to slightly > update the current documentation. The patchset adds > nothing new to the documentation, only fixes the old > description of hooks to reflect their current state. > > V2 adds the clarification on arguments for some hooks. > The format of the documentation is also slightly updated > for better html. However, there are still 10 hooks without > documentation at all. I think that this should be fixed > separatedly. > > Denis Efremov (11): > LSM: fix documentation for sb_copy_data hook > LSM: fix documentation for the syslog hook > LSM: fix documentation for the socket_post_create hook > LSM: fix documentation for the task_setscheduler hook > LSM: fix documentation for the socket_getpeersec_dgram hook > LSM: fix documentation for the path_chmod hook > LSM: fix documentation for the audit_* hooks > LSM: fix documentation for the msg_queue_* hooks > LSM: fix documentation for the sem_* hooks > LSM: fix documentation for the shm_* hooks > LSM: lsm_hooks.h: fix documentation format > > include/linux/lsm_hooks.h | 170 ++++++++++++++++++-------------------- > 1 file changed, 81 insertions(+), 89 deletions(-) Awesome; thanks! This fixes several warnings in "make htmldocs": ./include/linux/lsm_hooks.h:1783: warning: Function parameter or member 'task_setioprio' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1783: warning: Function parameter or member 'task_getioprio' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1783: warning: Function parameter or member 'task_movememory' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1783: warning: Function parameter or member 'secmark_refcount_inc' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1783: warning: Function parameter or member 'secmark_refcount_dec' not described in 'security_list_options' So, for the series: Acked-by: Kees Cook <keescook@xxxxxxxxxxxx> If you want more work, I do notice the following warnings are still present: ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'quotactl' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'quota_on' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'sb_free_mnt_opts' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'sb_eat_lsm_opts' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'sb_kern_mount' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'sb_show_options' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'sb_add_mnt_opt' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'd_instantiate' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'getprocattr' not described in 'security_list_options' ./include/linux/lsm_hooks.h:1775: warning: Function parameter or member 'setprocattr' not described in 'security_list_options' :) -- Kees Cook
