On Sat, Nov 3, 2018 at 4:27 AM <peng.hao2@xxxxxxxxxx> wrote: > > >> > >> On some architectures (e.g. arm64), it's preferable to use MMIO, since > >> this can be used standalone. Add MMIO support to the pvpanic driver. > >> > > > >0day complains b/c of 1st patch in the series. > > > >Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > >> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > > > >This wasn't suggested by me. It's your idea to support to MMIO. > > > oh, I just want to express that acpi_dev_resource_memory is your suggestion. > I misunderstood the use of the "Suggested-by'. No problem. Actually there is a room for interpretation. >From my point of view Suggested-by can be used in the following cases: - idea came from other person - the implementation of something is heavily based on other person's view (usually with provided code samples) In the patch which converts to use specific API idea was mine, but here I just reviewed one small part of the code, while idea is completely yours IIUC. Of course, you are free to give a credit if you would like to do so, just be little more specific. -- With Best Regards, Andy Shevchenko
