On Fri, Nov 2, 2018 at 6:46 AM Peng Hao <peng.hao2@xxxxxxxxxx> wrote:
>
> On some architectures (e.g. arm64), it's preferable to use MMIO, since
> this can be used standalone. Add MMIO support to the pvpanic driver.
>
0day complains b/c of 1st patch in the series.
Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> Suggested-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
This wasn't suggested by me. It's your idea to support to MMIO.
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx>
> ---
> drivers/misc/pvpanic.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index 49c59e1..22fb487 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -41,7 +41,7 @@
>
> #define PVPANIC_PANICKED (1 << 0)
>
> -static u16 port;
> +static void __iomem *base;
>
> static struct acpi_driver pvpanic_driver = {
> .name = "pvpanic",
> @@ -57,7 +57,7 @@
> static void
> pvpanic_send_event(unsigned int event)
> {
> - outb(event, port);
> + iowrite8(event, base);
> }
>
> static int
> @@ -80,7 +80,11 @@
> struct resource r;
>
> if (acpi_dev_resource_io(res, &r)) {
> - port = r.start;
> + base = (void __iomem *) ioport_map(r.start,
> + r.end - r.start + 1);
> + return AE_OK;
> + } else if (acpi_dev_resource_memory(res, &r)) {
> + base = ioremap(r.start, r.end - r.start + 1);
> return AE_OK;
> }
>
> @@ -101,7 +105,7 @@ static int pvpanic_add(struct acpi_device *device)
> acpi_walk_resources(device->handle, METHOD_NAME__CRS,
> pvpanic_walk_resources, NULL);
>
> - if (!port)
> + if (!base)
> return -ENODEV;
>
> atomic_notifier_chain_register(&panic_notifier_list,
> @@ -115,6 +119,8 @@ static int pvpanic_remove(struct acpi_device *device)
>
> atomic_notifier_chain_unregister(&panic_notifier_list,
> &pvpanic_panic_nb);
> + iounmap(base);
> +
> return 0;
> }
>
> --
> 1.8.3.1
>
--
With Best Regards,
Andy Shevchenko
