On Mon 2018-10-08 16:37:29, Geert Uytterhoeven wrote: > Hi Andy, > > On Mon, Oct 8, 2018 at 4:25 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote: > > > - Make the ptr argument const, to avoid adding casts in future > > > callers, > > > > > - Add a forward declaration, to avoid moving large blocks of code. > > > > How big it would be? ptr_to_id() itself plus... > > ... all the randomization helpers. > And ptr_to_id() needs pointer_string(), string(), widen_string(), number(), > and move_right(). > > 118 insertions(+), 120 deletions(-) > > Is that acceptable? Yes, it is acceptable. And my feeling is that it is the preferred solution is kernel because it helps to keep the code cleaner in the long term. I am for moving the code if there is no cyclic dependency. Best Regards, Petr
