On Mon, Oct 08, 2018 at 01:05:02PM +0200, Geert Uytterhoeven wrote: > - Make the ptr argument const, to avoid adding casts in future > callers, > - Add a forward declaration, to avoid moving large blocks of code. How big it would be? ptr_to_id() itself plus... > +static char *ptr_to_id(char *buf, char *end, const void *ptr, > + struct printf_spec spec); -- With Best Regards, Andy Shevchenko