On Tue, Jul 15, 2014 at 6:22 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Tuesday 15 July 2014 16:45:49 Ley Foon Tan wrote: >> diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h >> new file mode 100644 >> index 0000000..e726bfc >> --- /dev/null >> +++ b/arch/nios2/include/asm/gpio.h > This seems wrong. If any device drivers rely on this, better fix them to > use linux/gpio.h directly. Okay, will remove this file. >> +#ifndef __ASM_NIOS2_PCI_H__ >> +#define __ASM_NIOS2_PCI_H__ >> + >> +/* We don't support PCI yet, but some drivers require this file anyway */ >> + >> +#endif /* __ASM_NIOS2_PCI_H__ */ > > What's wrong with the generic version? Change to use generic pci.h. > >> +#ifndef _UAPI_ASM_NIOS2_STAT_H >> +#define _UAPI_ASM_NIOS2_STAT_H >> + >> +#include <asm-generic/stat.h> >> + >> +#endif > > This should just use the Kconfig logic to fall back on the generic file. Will use generic file. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
