On Tuesday 15 July 2014 16:45:49 Ley Foon Tan wrote: > diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h > new file mode 100644 > index 0000000..e726bfc > --- /dev/null > +++ b/arch/nios2/include/asm/gpio.h > @@ -0,0 +1,23 @@ > +/* > + * Copyright (C) 2013 Altera Corporation > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + * > + * This program is distributed in the hope it will be useful, but WITHOUT > + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for > + * more details. > + * > + * You should have received a copy of the GNU General Public License along with > + * this program. If not, see <http://www.gnu.org/licenses/>. > + * > + */ > + > +#ifndef _ASM_NIOS2_GPIO_H > +#define _ASM_NIOS2_GPIO_H > + > +#include <linux/gpio.h> > + > +#endif /* _ASM_NIOS2_GPIO_H */ This seems wrong. If any device drivers rely on this, better fix them to use linux/gpio.h directly. > diff --git a/arch/nios2/include/asm/pci.h b/arch/nios2/include/asm/pci.h > new file mode 100644 > index 0000000..69c86fa > --- /dev/null > +++ b/arch/nios2/include/asm/pci.h > @@ -0,0 +1,25 @@ > +/* > + * Copyright (C) 2013 Altera Corporation > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see <http://www.gnu.org/licenses/>. > + * > + */ > + > + > +#ifndef __ASM_NIOS2_PCI_H__ > +#define __ASM_NIOS2_PCI_H__ > + > +/* We don't support PCI yet, but some drivers require this file anyway */ > + > +#endif /* __ASM_NIOS2_PCI_H__ */ What's wrong with the generic version? > +#ifndef _UAPI_ASM_NIOS2_STAT_H > +#define _UAPI_ASM_NIOS2_STAT_H > + > +#include <asm-generic/stat.h> > + > +#endif This should just use the Kconfig logic to fall back on the generic file. > + > +#ifndef _UAPI_ASM_NIOS2_STATFS_H > +#define _UAPI_ASM_NIOS2_STATFS_H > + > +#define __statfs_word __s32 Why this? Every other architecture except parisc uses the default __u32 here. > +#include <linux/types.h> > +#include <asm-generic/swab.h> > + > +#ifdef CONFIG_NIOS2_CI_SWAB_SUPPORT > +#ifdef __GNUC__ > + > +#define __nios2_swab(x) \ > + __builtin_custom_ini(CONFIG_NIOS2_CI_SWAB_NO, (x)) > + > +static inline __attribute__((const)) __u16 __arch_swab16(__u16 x) > +{ > + return (__u16) __nios2_swab(((__u32) x) << 16); > +} Is this actually better than ___constant_swab16()? Also, have you checked if you need to support old compiler versions that don't have __builtin_bswap16/32/64? With newer compilers you don't need to define any of these yourself. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
