> >>> +/* sys_cacheflush -- flush the processor cache. */
> >>> +asmlinkage int sys_cacheflush(unsigned long addr, unsigned long len,
> >>> + unsigned int op)
> >>> +{
> >>> + struct vm_area_struct *vma;
> >>> +
> >>> + if (len == 0)
> >>> + return 0;
> >>
> >> op is being ignored? You should remove it... or if (op) return -EINVAL
> >> if you want future extensions.
> > Yes, op argument is being ignored. Okay, will add the return -EINVAL
> > if op is non-zero.
>
> Be careful. If existing applications already use this and maybe pass a
> dummy value
> to it you break them.
Well.. of course, but passing ignored integer to syscall, that can be
never used is beyond ugly. NAK-level ugly.
If it is so, you can never ever use the argument, and might as well
remove it (depending on your calling convention, it should not break
anything.)
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
