> >>>Sorry for the delay. It was a hectic week last week. > >>> > >>>As promised: > >>> > >>>>This patch adds ST Keyscan driver to use the keypad hw a subset > >>>>of ST boards provide. Specific board setup will be put in the > >>>>given dt. > >>>> > >>>>Signed-off-by: Giuseppe Condorelli<giuseppe.condorelli@xxxxxx> > >>>>Signed-off-by: Gabriel Fernandez<gabriel.fernandez@xxxxxx> > >>>Are you sure these are in the correct order? > >>ok i change the order > >I'm not saying they are in the wrong order, I'm just asking. Who wrote > >the patch? Has it changed since? > Sorry... > I wrote the patch, then Guiseppe has changed and tested, and I re-modifiedit Ah, then it starts to get very complicated. :) If you wrote the patch, you need to be at the top of the list. <snip> > >>>+keyscan: keyscan@fe4b0000 { > >>>+ compatible = "st,keypad"; > >>>Is there any way we can make this more specific to _this_ IP? > >>for my knowledge this IP is the same for stixxxx platform. > >So st,stix-keypad, or st,sti4x-keypad? > > > >I'm just thinking about future proofing the architecture. What if ST > >released stj which has a different keypad IP? > After discussing internally with st "st,sti-keyscan" is better Perfect. <snip> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html