On Sun, 16 Feb 2025 03:00:59 +0800 kernel test robot <lkp@xxxxxxxxx> wrote: > Hi Esteban, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on a64dcfb451e254085a7daee5fe51bf22959d52d3] > > url: https://github.com/intel-lab-lkp/linux/commits/Esteban-Blanc/dt-bindings-iio-adc-add-ADI-ad4030-ad4630-and-ad4632/20250214-202727 > base: a64dcfb451e254085a7daee5fe51bf22959d52d3 > patch link: https://lore.kernel.org/r/20250214-eblanc-ad4630_v1-v4-3-135dd66cab6a%40baylibre.com > patch subject: [PATCH v4 3/6] iio: adc: ad4030: add averaging support > config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20250216/202502160240.IoVS8Klu-lkp@xxxxxxxxx/config) > compiler: alpha-linux-gcc (GCC) 14.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250216/202502160240.IoVS8Klu-lkp@xxxxxxxxx/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@xxxxxxxxx> > | Closes: https://lore.kernel.org/oe-kbuild-all/202502160240.IoVS8Klu-lkp@xxxxxxxxx/ > > All warnings (new ones prefixed by >>): > > drivers/iio/adc/ad4030.c: In function 'ad4030_get_chan_scale': > >> drivers/iio/adc/ad4030.c:375:27: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] > 375 | scan_type = iio_get_current_scan_type(indio_dev, > | ^ > > I applied diff --git a/drivers/iio/adc/ad4030.c b/drivers/iio/adc/ad4030.c index ed31a3d1d13b..d026535e5d9b 100644 --- a/drivers/iio/adc/ad4030.c +++ b/drivers/iio/adc/ad4030.c @@ -369,7 +369,7 @@ static int ad4030_get_chan_scale(struct iio_dev *indio_dev, int *val2) { struct ad4030_state *st = iio_priv(indio_dev); - struct iio_scan_type *scan_type; + const struct iio_scan_type *scan_type; if (chan->differential) { scan_type = iio_get_current_scan_type(indio_dev, Whilst picking this up. > vim +/const +375 drivers/iio/adc/ad4030.c > > 365 > 366 static int ad4030_get_chan_scale(struct iio_dev *indio_dev, > 367 struct iio_chan_spec const *chan, > 368 int *val, > 369 int *val2) > 370 { > 371 struct ad4030_state *st = iio_priv(indio_dev); > 372 struct iio_scan_type *scan_type; > 373 > 374 if (chan->differential) { > > 375 scan_type = iio_get_current_scan_type(indio_dev, > 376 st->chip->channels); > 377 *val = (st->vref_uv * 2) / MILLI; > 378 *val2 = scan_type->realbits; > 379 return IIO_VAL_FRACTIONAL_LOG2; > 380 } > 381 > 382 *val = st->vref_uv / MILLI; > 383 *val2 = chan->scan_type.realbits; > 384 return IIO_VAL_FRACTIONAL_LOG2; > 385 } > 386 >
