On 11/02/2025 2:27, Jakub Kicinski wrote: > On Sun, 9 Feb 2025 09:59:22 +0200 Gal Pressman wrote: >> I don't understand the rationale, the new input_xfrm field didn't >> deserve a selftest, why does a new value to the field does? > > Ahmed and Sudheer added ETHTOOL_MSG_RSS_GET as part of their work. > Everyone pays off a little bit of technical debt to get their > feature in. I agree with the idea that extensions to ethtool uapi should be accompanied by conversion to netlink. I don't see a connection to testing. If a maintainer has certain expectations about which changes require tests, it should be documented and enforced so it's not up to the maintainer's mood. FWIW, I don't believe kernel contributions should be blocked by lack of a test. > > I don't appreciate your reaction. Please stop acting as if nVidia was > a victim of some grand conspiracy within netdev. I don't know what you're talking about, you've mistaken me for someone else.. > >> Testing this would require new userspace ethtool (which has not been >> submitted yet), I don't think it's wise to implement a test before the >> user interface/output is merged. > > No it doesn't. You can call netlink directly from Python or C. > >> I assume you want an additional case in rss_ctx.py? > > No, separate test. Will address in v3.
