On Sun, 9 Feb 2025 09:59:22 +0200 Gal Pressman wrote: > I don't understand the rationale, the new input_xfrm field didn't > deserve a selftest, why does a new value to the field does? Ahmed and Sudheer added ETHTOOL_MSG_RSS_GET as part of their work. Everyone pays off a little bit of technical debt to get their feature in. I don't appreciate your reaction. Please stop acting as if nVidia was a victim of some grand conspiracy within netdev. > Testing this would require new userspace ethtool (which has not been > submitted yet), I don't think it's wise to implement a test before the > user interface/output is merged. No it doesn't. You can call netlink directly from Python or C. > I assume you want an additional case in rss_ctx.py? No, separate test.