Hi Babu, On 2/6/25 2:57 PM, Moger, Babu wrote: > On 2/6/2025 12:42 PM, Reinette Chatre wrote: >> On 2/6/25 8:15 AM, Moger, Babu wrote: >>> On 2/5/2025 4:49 PM, Reinette Chatre wrote: >>>> On 1/22/25 12:20 PM, Babu Moger wrote: >>> >>> I will have to introduce another function to reset RMIDs in all the domains. Also, make sure it is called from both these places. >>> >>> list_for_each_entry(dom, &r->mon_domains, hdr.list) >>> resctrl_arch_reset_rmid_all(r, dom); >> >> I do not see need for new functions, except the one I mention in >> https://lore.kernel.org/lkml/b60b4f72-6245-46db-a126-428fb13b6310@xxxxxxxxx/ >> that suggests a new helper for reset of architectural state that does not >> exist and ends up being open coded in two places in this series. >> >> With only one place (resctrl_mbm_assign_mode_write()) remaining that needs >> all state reset I think it will be easier to understand if the state reset >> is open coded within it, replacing mbm_cntr_reset() with: >> >> list_for_each_entry(dom, &r->mon_domains, hdr.list) { >> mbm_cntr_free_all() >> resctrl_reset_rmid_all() // Just for architectural state >> } > > You meant "Just for non-architectural state" ? Yes, thank you, what a confusion causing typo. Reinette
