Best Regards. Anson huang 黄勇才 Freescale Semiconductor Shanghai 上海浦东新区亮景路192号A座2楼 201203 Tel:021-28937058 >-----Original Message----- >From: Baruch Siach [mailto:baruch@xxxxxxxxxx] >Sent: Thursday, December 19, 2013 2:25 PM >To: Huang Yongcai-B20788 >Cc: shawn.guo@xxxxxxxxxx; kernel@xxxxxxxxxxxxxx; rui.zhang@xxxxxxxxx; >eduardo.valentin@xxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; >linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-doc@xxxxxxxxxxxxxxx >Subject: Re: [PATCH 2/3] thermal: imx: add necessary clk operation > >Hi Anson, > >On Thu, Dec 19, 2013 at 01:17:24PM -0500, Anson Huang wrote: >> + if (IS_ERR(data->thermal_clk)) { >> + ret = IS_ERR(data->thermal_clk); > >You probably what to return PTR_ERR here. > Yes, thanks, will fix it in V2. [Anson] >baruch > >> + dev_err(&pdev->dev, "failed to get thermal clk!\n"); >> + return ret; >> + } > >-- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems >=}------------------------------------------------ooO--U--Ooo------------{= > - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il - > ��.n��������+%������w��{.n�����{����* jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
