Hello Krzysztof, On Sat, 4 Jan 2025 10:44:49 +0100 Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > On Fri, Jan 03, 2025 at 10:13:16PM +0100, Kory Maincent wrote: > > From: Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx> > > > > Add an interrupt property to the device tree bindings for the TI TPS23881 > > PSE controller. The interrupt is primarily used to detect classification > > and disconnection events, which are essential for managing the PSE > > controller in compliance with the PoE standard. > > > > @@ -62,6 +65,7 @@ unevaluatedProperties: false > > required: > > - compatible > > - reg > > + - interrupts > > Why? That's an ABI change. Commit msg mentions something like "essential > for standard" so are you saying nothing here was working according to > standard before? Yes indeed, the disconnection management did not follow the standard. Without this series, the power on the ports of this controller is not shut down after a Powered Device disconnection. Unfortunately, I did not noticed this before. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com
