Re: [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Taehee Yoo <ap420073@xxxxxxxxx>
Subject: Re: [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Wed, 18 Dec 2024 18:44:44 -0800
Cc: davem@xxxxxxxxxxxxx, pabeni@xxxxxxxxxx, edumazet@xxxxxxxxxx, almasrymina@xxxxxxxxxx, donald.hunter@xxxxxxxxx, corbet@xxxxxxx, michael.chan@xxxxxxxxxxxx, andrew+netdev@xxxxxxx, hawk@xxxxxxxxxx, ilias.apalodimas@xxxxxxxxxx, ast@xxxxxxxxxx, daniel@xxxxxxxxxxxxx, john.fastabend@xxxxxxxxx, dw@xxxxxxxxxxx, sdf@xxxxxxxxxxx, asml.silence@xxxxxxxxx, brett.creeley@xxxxxxx, linux-doc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kory.maincent@xxxxxxxxxxx, maxime.chevallier@xxxxxxxxxxx, danieller@xxxxxxxxxx, hengqi@xxxxxxxxxxxxxxxxx, ecree.xilinx@xxxxxxxxx, przemyslaw.kitszel@xxxxxxxxx, hkallweit1@xxxxxxxxx, ahmed.zaki@xxxxxxxxx, rrameshbabu@xxxxxxxxxx, idosch@xxxxxxxxxx, jiri@xxxxxxxxxxx, bigeasy@xxxxxxxxxxxxx, lorenzo@xxxxxxxxxx, jdamato@xxxxxxxxxx, aleksander.lobakin@xxxxxxxxx, kaiyuanz@xxxxxxxxxx, willemb@xxxxxxxxxx, daniel.zahka@xxxxxxxxx
In-reply-to: <20241218144530.2963326-9-ap420073@gmail.com>
References: <20241218144530.2963326-1-ap420073@gmail.com> <20241218144530.2963326-9-ap420073@gmail.com>

On Wed, 18 Dec 2024 14:45:29 +0000 Taehee Yoo wrote:
> +	     bpf->command == XDP_SETUP_PROG_HW) &&

PROG_HW will be fine, you can drop this part of the check.
HDS is a host feature, if the program is offloaded offload driver
does much more precise geometry validation already.

Follow-Ups:
- Re: [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.
  - From: Taehee Yoo

References:
- [PATCH net-next v6 0/9] bnxt_en: implement tcp-data-split and thresh option
  - From: Taehee Yoo
- [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.
  - From: Taehee Yoo

Prev by Date: Re: [PATCH net-next v6 3/9] bnxt_en: add support for tcp-data-split ethtool command
Next by Date: Re: [PATCH net-next v6 9/9] netdevsim: add HDS feature
Previous by thread: [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.
Next by thread: Re: [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]