On Wed, 18 Dec 2024 18:25:47 -0800 Jakub Kicinski wrote: > > + if (prog && bp->flags & BNXT_FLAG_HDS) { > > + netdev_warn(dev, "XDP is disallowed when HDS is enabled.\n"); > > + return -EOPNOTSUPP; > > + } > > And this check should also live in the core, now that core has access > to dev->ethtool->hds_config ? I think you can add this check to the > core in the same patch as the chunk referred to above. Oh, you also already have this logic in patch 7? So it just needs to be reordered in the series, and then the driver doesn't need to check?