> > > +static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
> > > + const void __iomem *addr)
> > > +{
> > > + if (likely(fpc->big_endian))
> > > + return ioread32be(addr);
> > > + else
> > > + return readl(addr);
> > > +}
>
> It looks a little odd to to have two different accessors here.
>
> Could these not be unified somehow?
>
How about the following :
+static inline u32 fsl_pwm_readl(struct fsl_pwm_chip *fpc,
+ const void __iomem *addr)
+{
+ u32 val;
+
+ if (likely(fpc->big_endian))
+ val = be32_to_cpu(__raw_readl(addr));
+ else
+ val = le32_to_cpu(__raw_readl(addr));
+
+ rmb();
+
+ return val;
+}
+
+static inline void fsl_pwm_writel(struct fsl_pwm_chip *fpc,
+ u32 val, void __iomem *addr)
+{
+ wmb();
+
+ if (likely(fpc->big_endian))
+ __raw_writel(cpu_to_be32(val), addr);
+ else
+ __raw_writel(cpu_to_le32(val), addr);
+}
+
> > > +static inline void fsl_pwm_writel(struct fsl_pwm_chip *fpc,
> > > + u32 val, void __iomem *addr)
> > > +{
> > > + if (likely(fpc->big_endian))
> > > + iowrite32be(val, addr);
> > > + else
> > > + writel(val, addr);
> > > +}
>
> Likewise.
>
> [...]
>
> > > +static int fsl_pwm_probe(struct platform_device *pdev) {
> > > + int ret;
> > > + struct fsl_pwm_chip *fpc;
> > > + struct resource *res;
> > > + struct device_node *np = pdev->dev.of_node;
> > > +
> > > + fpc = devm_kzalloc(&pdev->dev, sizeof(*fpc), GFP_KERNEL);
> > > + if (!fpc)
> > > + return -ENOMEM;
> > > +
> > > + mutex_init(&fpc->lock);
> > > +
> > > + fpc->chip.dev = &pdev->dev;
> > > +
> > > + if (of_get_property(np, "big-endian", NULL))
> > > + fpc->big_endian = 1;
>
> You can use of_property_read_bool:
>
> fpc->big_endian = of_property_read_bool(np, "big-endian");
>
> Otherwise, the DT stuff looks fine.
>
That sounds good.
--
Xiubo,
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
