在 2024/11/5 22:47, Jonathan Corbet 写道:
Yanteng Si <si.yanteng@xxxxxxxxx> writes:
在 2024/11/5 03:27, Jonathan Corbet 写道:
OK, I have applied this patch. A couple of comments for future reference:
<xu.xin16@xxxxxxxxxx> writes:
Update to commit 7332f9e45d2e("docs/mm: Physical Memory: Fix grammar")
...and this I don't understand at all; why do you need to reference that
patch here?
We use it to mark the progress of the translation against
the original document. If we don't put this tag on at the
very beginning, when the translation falls behind the original
document for a while, we'll have to go through the whole
original document log from the very top downwards, which
is an enormous amount of work. On the other hand, the
checktransupdate.py also works based on this tag.
Yeah, this tag might seem a bit ambiguous. I think maybe
we could improve it? For example:
Trans_mark commit 7332f9e45d2e ("docs/mm: Physical Memory: Fix grammar")
"Update to commit xxx" suggests that the current patch is somehow
changing that commit. "Update the translation through commit xxxx"
would be a bit clearer in that regard. I think it's better to stay with
something resembling plain language rather than adding a new pseudo-tag
that outsiders won't understand.
Approve!
Thanks,
Yanteng
Thanks,
jon
