Re: [PATCH v5 0/2] dt-bindings: hwmon: pmbus: add bindings for isl68137

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 28, 2024 at 11:18:39AM +0100, Geert Uytterhoeven wrote:
> > v4:
> > - Revert devicetree property name to "vout-voltage-divider" and refactor
> >   property description and driver implementation to match existing
> >   vout-voltage-divider implementation in max20730 as no suitable generic
> >   voltage divider schema exists.
> 
> Can you please elaborate (or point to the email that did so, in case
> I missed it)?
> 
> In reply to v2, Günter wrote:
> 
>    "I would prefer, in the order of preference,
> 
>     1) an applicable generic property definition
>     2) a definition that is already used elsewhere
>     3) a new chips specific definition"
> 
> https://lore.kernel.org/all/3f460b62-4cd1-49dd-a98b-1fbcfdbd3af0@xxxxxxxxxxxx
> 
> Thanks!
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
>

Hi Geert,

After looking through existing bindings definitions, the only generic
voltage divider property that I found was one that is intended to scale
voltages for IIO io-channels. However, the use case here is to scale
particular hwmon PMBus telemetry, which most closely matches the existing
implementation of the vout-voltage-divider property in the max20730
driver so I opted to copy that implementation based on Guenter's
preferences. Is there something that I missed or more information that
you are looking for?

Thanks,
Grant




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux