Re: [PATCH v5 0/2] dt-bindings: hwmon: pmbus: add bindings for isl68137

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Grant,

On Fri, Oct 25, 2024 at 7:16 PM Grant Peltier <grantpeltier93@xxxxxxxxx> wrote:
> Renesas digital multiphase voltage regulators are capable of regulating
> output voltages that exceed the range that their Vsense pins can detect.
> In such applications, users may place a voltage divider between Vout and
> the Vsense pin for a given rail. However, the driver currently has no
> way of knowing if a voltage divider is being used which results in
> erroneous telemetry being reported over hwmon.
>
> This patch set defines a devicetree bindings schema for Renesas digital
> multiphase voltage regulators that are supported by the isl68137 driver
> to allow users to add voltage divider definitions for any rail powered
> by the device. This patch set also includes the required changes to the
> isl68137 driver to enable scaling Vout/Pout telemetry for rails with a
> defined voltage divider.
>
> v5:
> - Fix clang compilation errors related to C23 syntax

Thanks for the update!

> v4:
> - Revert devicetree property name to "vout-voltage-divider" and refactor
>   property description and driver implementation to match existing
>   vout-voltage-divider implementation in max20730 as no suitable generic
>   voltage divider schema exists.

Can you please elaborate (or point to the email that did so, in case
I missed it)?

In reply to v2, Günter wrote:

   "I would prefer, in the order of preference,

    1) an applicable generic property definition
    2) a definition that is already used elsewhere
    3) a new chips specific definition"

https://lore.kernel.org/all/3f460b62-4cd1-49dd-a98b-1fbcfdbd3af0@xxxxxxxxxxxx

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux