Hi,
On Mon, Nov 11, 2013 at 08:06:12PM +0530, Kishon Vijay Abraham I wrote:
> >> diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h
> >> index 7db34f0..49ffa6d 100644
> >> --- a/drivers/usb/dwc3/platform_data.h
> >> +++ b/drivers/usb/dwc3/platform_data.h
> >> @@ -24,4 +24,6 @@ struct dwc3_platform_data {
> >> enum usb_device_speed maximum_speed;
> >> enum usb_dr_mode dr_mode;
> >> bool tx_fifo_resize;
> >> + bool usb2_phy;
> >> + bool usb3_phy;
> >
> > This would look better as a quirks flag, then we could:
> >
> > unsigned long quirks;
> > #define DWC3_QUIRK_NO_USB3_PHY BIT(0)
> > #define DWC3_QUIRK_NO_USB2_PHY BIT(1)
>
> Should this quirk be used for dt also? Currently we find if it has usb3 phy or
> usb2 phy from the dt data only. But if we add a quirk, we'll have to add a
> property to populate the quirk no?
either we use the quirk, or use the fact that no <&usb2_phy> phandle is
defined, would work both ways, no ?
--
balbi
Attachment:
signature.asc
Description: Digital signature
