On 16/10/2024 06:16, Hangbin Liu wrote: > When a slave already has an XDP program loaded, the correct return value > should be -EEXIST instead of -EOPNOTSUPP. > > Fixes: 9e2ee5c7e7c3 ("net, bonding: Add XDP support to the bonding driver") > Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx> > --- > drivers/net/bonding/bond_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index f0f76b6ac8be..6887a867fe8b 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -5699,7 +5699,7 @@ static int bond_xdp_set(struct net_device *dev, struct bpf_prog *prog, > if (dev_xdp_prog_count(slave_dev) > 0) { > SLAVE_NL_ERR(dev, slave_dev, extack, > "Slave has XDP program loaded, please unload before enslaving"); > - err = -EOPNOTSUPP; > + err = -EEXIST; > goto err; > } > Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>