On 16/10/2024 06:16, Hangbin Liu wrote: > Bonding only supports native XDP for specific modes, which can lead to > confusion for users regarding why XDP loads successfully at times and > fails at others. This patch enhances error handling by returning detailed > error messages, providing users with clearer insights into the specific > reasons for the failure when loading native XDP. > > Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx> > --- > drivers/net/bonding/bond_main.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > index b1bffd8e9a95..f0f76b6ac8be 100644 > --- a/drivers/net/bonding/bond_main.c > +++ b/drivers/net/bonding/bond_main.c > @@ -5676,8 +5676,11 @@ static int bond_xdp_set(struct net_device *dev, struct bpf_prog *prog, > > ASSERT_RTNL(); > > - if (!bond_xdp_check(bond)) > + if (!bond_xdp_check(bond)) { > + BOND_NL_ERR(dev, extack, > + "No native XDP support for the current bonding mode"); > return -EOPNOTSUPP; > + } > > old_prog = bond->xdp_prog; > bond->xdp_prog = prog; I guess this is based on our discussion earlier? Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>