Re: [PATCH v2 1/6] Add AutoFDO support for Clang build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 04, 2024 at 02:23:45PM -0700, Justin Stitt wrote:
> On Fri, Oct 4, 2024 at 11:29 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> >
> > On Fri, Oct 04, 2024 at 11:10:04AM -0700, Kees Cook wrote:
> >
> > > +Configure the kernel with::(make)
> > > +
> > > +     CONFIG_AUTOFDO_CLANG=y
> > >
> > > Then we could avoid the extra 2 lines but still gain the rendered language
> > > highlights?
> >
> > The whole double-colon thing is already a pain to read; you're making it
> > worse again.
> 
> Lots of people read docs on the web and having code blocks with
> monospaced fonts (+syntax highlighting) makes them easier to read
> there.
> 
> Configure the kernel with:
> 
>      CONFIG_AUTOFDO_CLANG=y
> 
> --versus--
> 
> Configure the kernel with::
> 
>      CONFIG_AUTOFDO_CLANG=y
> 
> This renders better for html through Sphinx and really can't be that
> bad to read in vim, can it?

It's weird; but I've gotten sorta used to it. I was more or less
commenting on Kees' proposal of making it:

  Configure the kernel with::(make)

Which is definitely harder to read since it insta triggers a syntax
error exception in my head.




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux