On 10/09/2024 11:31, Jerome Brunet wrote: >>> + >>> + interrupts: >>> + description: PMBUS SMB Alert Interrupt. >>> + maxItems: 1 >>> + >>> + regulators: >>> + type: object >>> + description: >>> + list of regulators provided by this controller. >> >> You have just one regulator, so drop "regulators" node and use directly >> vout here. > > Just took the example the other pmbus device and did the same for > consistency. > > In that case, there other (possible) regulator called gpdac1 and gpdac2. > I haven't even tried to implement the support for those. Your binding should be complete. Does not matter whether you implemented it in drivers or not. > > Since it would not break old DTs to add that later, I thought it would be OK > to add them later. Should I add them now ? This should be added now. Best regards, Krzysztof