Re: [PATCH 1/3] dt-bindings: hwmon: pmbus: add ti tps25990 documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 09, 2024 at 05:39:03PM +0200, Jerome Brunet wrote:
> Add DT binding documentation for the Texas Instruments TPS25990 eFuse
> 
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> ---
>  .../bindings/hwmon/pmbus/ti,tps25990.yaml          | 73 ++++++++++++++++++++++
>  1 file changed, 73 insertions(+)
>

A nit, subject: drop second/last, redundant "documentation". The
"dt-bindings" prefix is already stating that these are bindings/docs.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml
> new file mode 100644
> index 000000000000..e717942b3598
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +

Drop blank line.

> +$id: http://devicetree.org/schemas/hwmon/pmbus/ti,tps25990.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TPS25990 Stackable eFuse
> +
> +maintainers:
> +  - Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The TI TPS25990 is an integrated, high-current circuit
> +  protection and power management device with PMBUS interface
> +
> +properties:
> +  compatible:
> +    const: ti,tps25990
> +
> +  reg:
> +    maxItems: 1
> +
> +  ti,rimon-milli-ohms:
> +    description:
> +      milli Ohms value of the resistance installed between the Imon pin
> +      and the ground reference.

Ohms is not enough? We don't have mOhm in property units.
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

> +
> +  interrupts:
> +    description: PMBUS SMB Alert Interrupt.
> +    maxItems: 1
> +
> +  regulators:
> +    type: object
> +    description:
> +      list of regulators provided by this controller.

You have just one regulator, so drop "regulators" node and use directly
vout here.

> +
> +    properties:
> +      vout:
> +        $ref: /schemas/regulator/regulator.yaml#
> +        type: object
> +        unevaluatedProperties: false
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - ti,rimon-milli-ohms
> +
> +additionalProperties: false

Best regards,
Krzysztof





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux