On Fri, Aug 16, 2024 at 09:44:12AM -0500, Ira Weiny wrote: > The event buffer does not need to be allocated if something has failed in > setting up event irq's. > > In prep for adjusting event configuration for DCD events move the buffer > allocation to the end of the event configuration. > > Reviewed-by: Davidlohr Bueso <dave@xxxxxxxxxxxx> > Reviewed-by: Dave Jiang <dave.jiang@xxxxxxxxx> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx> > > --- Reviewed-by: Fan Ni <fan.ni@xxxxxxxxxxx> > Changes: > [iweiny: keep tags for early simple patch] > [Davidlohr, Jonathan, djiang: move to beginning of series] > [Dave feel free to pick this up if you like] > --- > drivers/cxl/pci.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c > index 4be35dc22202..3a60cd66263e 100644 > --- a/drivers/cxl/pci.c > +++ b/drivers/cxl/pci.c > @@ -760,10 +760,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, > return 0; > } > > - rc = cxl_mem_alloc_event_buf(mds); > - if (rc) > - return rc; > - > rc = cxl_event_get_int_policy(mds, &policy); > if (rc) > return rc; > @@ -777,6 +773,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, > return -EBUSY; > } > > + rc = cxl_mem_alloc_event_buf(mds); > + if (rc) > + return rc; > + > rc = cxl_event_irqsetup(mds); > if (rc) > return rc; > > -- > 2.45.2 >
