On Thu, Oct 24, 2013 at 09:29:42AM +0100, Jonathan Cameron wrote: > On 10/23/13 22:51, Sebastian Reichel wrote: > > Add Device Tree support for the TSL2563 driver > > and document the binding. > > > > Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx> > > --- > > .../devicetree/bindings/iio/light/tsl2563.txt | 19 +++++++++++++++++++ > > drivers/iio/light/tsl2563.c | 4 ++++ > > 2 files changed, 23 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2563.txt > > > > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2563.txt b/Documentation/devicetree/bindings/iio/light/tsl2563.txt > > new file mode 100644 > > index 0000000..b52cf4b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/light/tsl2563.txt > > @@ -0,0 +1,19 @@ > > +* TAOS TSL2563 ambient light sensor > > + > > +Required properties: > > + > > + - compatible : should be "taos,tsl2563" > > + - reg : the I2C address of the sensor > > + > > +Optional properties: > > + > So two options for this one. Either pitch it as a possible general parameter, or > mark it with a vendor prefix. It seems like something fairly general, but in that case it > probably needs a more detailed proposal and explanation of exactly what it is. OK, I will add a vendor prefix in a PATCHv2. When I converted the driver to DT I had a look how this is used and I don't think it's "fairly general". > Also, is taos listed in vendor-prefixes.txt? Jon, is that the right vendor prefix to use? > I'm guessing you have some non mainline bindings out there already so it would be good > to match those... taos is currently not listed in the vendor-prefixes.txt file. Also it seems that "TAOS Inc." has been absorbed by "ams AG" in 2011. So how to proceed with the patch? -- Sebastian
Attachment:
signature.asc
Description: Digital signature
