On 10/23/13 22:51, Sebastian Reichel wrote:
> Add Device Tree support for the TSL2563 driver
> and document the binding.
>
> Signed-off-by: Sebastian Reichel <sre@xxxxxxxxxx>
> ---
> .../devicetree/bindings/iio/light/tsl2563.txt | 19 +++++++++++++++++++
> drivers/iio/light/tsl2563.c | 4 ++++
> 2 files changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2563.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/light/tsl2563.txt b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
> new file mode 100644
> index 0000000..b52cf4b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
> @@ -0,0 +1,19 @@
> +* TAOS TSL2563 ambient light sensor
> +
> +Required properties:
> +
> + - compatible : should be "taos,tsl2563"
> + - reg : the I2C address of the sensor
> +
> +Optional properties:
> +
So two options for this one. Either pitch it as a possible general parameter, or
mark it with a vendor prefix. It seems like something fairly general, but in that case it
probably needs a more detailed proposal and explanation of exactly what it is.
Also, is taos listed in vendor-prefixes.txt? Jon, is that the right vendor prefix to use?
I'm guessing you have some non mainline bindings out there already so it would be good
to match those...
> + - cover-comp-gain : integer used as multiplier for gain
> + compensation (default = 1)
> +
> +Example:
> +
> +tsl2563@29 {
> + compatible = "taos,tsl2563";
> + reg = <0x29>;
> + cover-comp-gain = <16>;
> +};
> diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
> index ebb962c..bd30b1d 100644
> --- a/drivers/iio/light/tsl2563.c
> +++ b/drivers/iio/light/tsl2563.c
> @@ -699,6 +699,7 @@ static int tsl2563_probe(struct i2c_client *client,
> struct iio_dev *indio_dev;
> struct tsl2563_chip *chip;
> struct tsl2563_platform_data *pdata = client->dev.platform_data;
> + struct device_node *np = client->dev.of_node;
> int err = 0;
> u8 id = 0;
>
> @@ -735,6 +736,9 @@ static int tsl2563_probe(struct i2c_client *client,
>
> if (pdata)
> chip->cover_comp_gain = pdata->cover_comp_gain;
> + else if (np)
> + of_property_read_u32_index(np, "cover-comp-gain", 0,
> + &chip->cover_comp_gain);
> else
> chip->cover_comp_gain = 1;
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
