Hi Reinette,
On 5/7/2024 3:27 PM, Reinette Chatre wrote:
Hi Babu,
On 5/6/2024 1:23 PM, Moger, Babu wrote:
On 5/3/24 18:26, Reinette Chatre wrote:
Hi Babu,
In shortlog, please use () to indicate function:
resctrl_file_fflags_init().
On 3/28/2024 6:06 PM, Babu Moger wrote:
Consolidate multiple fflags initialization into one function.
Remove thread_throttle_mode_init, mbm_config_rftype_init and
consolidate them into resctrl_file_fflags_init.
This changelog has no context and only describes what the code does,
which can be learned from reading the patch. Could you please
update changelog with context and motivation for this change?
How about this?
Consolidate multiple fflags initialization into one function.
The functions thread_throttle_mode_init() and mbm_config_rftype_init()
both initialize fflags for resctrl files. This can be simplified into one
function passing the file name and flags to be initialized. It also helps
code simplification of new flags initialized for ABMC feature.
I am not sure what you intend here. Is this the entire intended changelog?
I expected it to reflect x86 requirements as per
Documentation/process/maintainer-tip.rst. Under "Changelog":
"It's also useful to structure the changelog into several paragraphs and not
lump everything together into a single one. A good structure is to explain
the context, the problem and the solution in separate paragraphs and this
order."
I will try to elaborate this in next version.
Thanks
- Babu Moger
