On Tue, 26 Mar 2024 00:51:21 -0700 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > On Mon, Mar 25, 2024 at 11:20 AM SeongJae Park <sj@xxxxxxxxxx> wrote: > > > > On Mon, 25 Mar 2024 10:59:01 -0700 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > > > On Mon, Mar 25, 2024 at 10:49 AM SeongJae Park <sj@xxxxxxxxxx> wrote: > > > > > > > > On Mon, 25 Mar 2024 14:56:01 +0000 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > > > > > > > On Sat, Mar 23, 2024 at 6:05 PM SeongJae Park <sj@xxxxxxxxxx> wrote: > > > > > > > > > > > > Hi Suren and Kent, > > > > > > > > > > > > On Thu, 21 Mar 2024 09:36:52 -0700 Suren Baghdasaryan <surenb@xxxxxxxxxx> wrote: > > > > > > > > > > > > > From: Kent Overstreet <kent.overstreet@xxxxxxxxx> > > > > > > > > > > > > > > This wrapps all external vmalloc allocation functions with the > > > > > > > alloc_hooks() wrapper, and switches internal allocations to _noprof > > > > > > > variants where appropriate, for the new memory allocation profiling > > > > > > > feature. > > > > > > > > > > > > I just noticed latest mm-unstable fails running kunit on my machine as below. > > > > > > 'git-bisect' says this is the first commit of the failure. > > > > > > > > > > > > $ ./tools/testing/kunit/kunit.py run --build_dir ../kunit.out/ > > > > > > [10:59:53] Configuring KUnit Kernel ... > > > > > > [10:59:53] Building KUnit Kernel ... > > > > > > Populating config with: > > > > > > $ make ARCH=um O=../kunit.out/ olddefconfig > > > > > > Building with: > > > > > > $ make ARCH=um O=../kunit.out/ --jobs=36 > > > > > > ERROR:root:/usr/bin/ld: arch/um/os-Linux/main.o: in function `__wrap_malloc': > > > > > > main.c:(.text+0x10b): undefined reference to `vmalloc' > > > > > > collect2: error: ld returned 1 exit status > > > > > > > > > > > > Haven't looked into the code yet, but reporting first. May I ask your idea? > > > > > > > > > > Hi SeongJae, > > > > > Looks like we missed adding "#include <linux/vmalloc.h>" inside > > > > > arch/um/os-Linux/main.c in this patch: > > > > > https://lore.kernel.org/all/20240321163705.3067592-2-surenb@xxxxxxxxxx/. > > > > > I'll be posing fixes for all 0-day issues found over the weekend and > > > > > will include a fix for this. In the meantime, to work around it you > > > > > can add that include yourself. Please let me know if the issue still > > > > > persists after doing that. > > > > > > > > Thank you, Suren. The change made the error message disappears. However, it > > > > introduced another one. > > > > > > Ok, let me investigate and I'll try to get a fix for it today evening. > > > > Thank you for this kind reply. Nonetheless, this is not blocking some real > > thing from me. So, no rush. Plese take your time :) > > I posted a fix here: > https://lore.kernel.org/all/20240326073750.726636-1-surenb@xxxxxxxxxx/ > Please let me know if this resolves the issue. I confirmed it is fixing the issue, and replied to the patch with my Tested-by: tag. Thank you for this kind fix, Suren. Thanks, SJ [...]
