Hi Krzysztof, On 22/03/24 12:33 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 22/03/2024 07:25, Parthiban.Veerasooran@xxxxxxxxxxxxx wrote: >>>> properties: >>>> compatible: >>>> oneOf: >>>> - items: >>>> - const: microchip,lan8651 >>>> - const: microchip,lan8650 >>> No, this is not right either. You need to also allow the lan8650 on its >>> own. All you had to do with the original items list was flip the order >>> of the lan8650 and lan8651. >> Ah ok, now I understand this. Then it is supposed to be like below, >> >> properties: >> >> compatible: >> >> oneOf: >> >> - const: microchip,lan8650 >> >> - items: >> >> - const: microchip,lan8651 >> >> - const: microchip,lan8650 >> >> Executed dt_binding_check with the above update and it was successful. >> Hope this is OK? > > This is the third time you ask us. None of the previous cases were > actually tested. Maybe this one was, maybe not. I assume the latter. > > First, test your code. As I mentioned in the previous email itself, I tested this case and the previous case both in my RPI 4 setup before replying to the comment. The question I ask is to check whether the person who comments is OK with the changes or not. Didn't you see the attachments in my previous email which I used in my RPI 4 dts setup for my testing? if not I can forward it again. Best regards, Parthiban V > > Best regards, > Krzysztof >