Hello Oleksij, On Mon, 4 Mar 2024 11:31:19 +0100 Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote: > > > > > Should be tested, but if, instead of "vin-supply", we will use > > > "pse-supply" it will make most part of pse_regulator.c obsolete. > > > > Don't know, if it is done at the pse-pi node level it may not break > > pse_regulator.c. Not sure about it. > > me too. Before your patch set, the regulator topology for PoDL PSE was > following: > power-source > fixed-regulator > PoDL_PSE-consumer > > Now it will be: > power-source > fixed-regulator > PoDL_PSE-consumer > PSE-PI-provider > PSE-PI-consumer > > By porting porting PSE framework to regulator, probably it make sense to > remove two levels of regulators? > power-source > fixed-regulator > PSE-PI-consumer Sorry, I forgot to reply about this. This is specific to pse_regulator driver. Could we tackle this change in another patch series when the current patch series got applied? Also I don't have the hardware to test it. Regards, -- Köry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com