Hi Conor, On 06/03/24 11:46 pm, Conor Dooley wrote: > On Wed, Mar 06, 2024 at 02:20:17PM +0530, Parthiban Veerasooran wrote: >> The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet >> PHY to enable 10BASE-T1S networks. The Ethernet Media Access Controller >> (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible >> with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver >> integrated into the LAN8650/1. The communication between the Host and the >> MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial >> Interface (TC6). >> >> Signed-off-by: Parthiban Veerasooran<Parthiban.Veerasooran@xxxxxxxxxxxxx> >> --- >> .../bindings/net/microchip,lan865x.yaml | 80 +++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 81 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> new file mode 100644 >> index 000000000000..ee52f9d8e93c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml >> @@ -0,0 +1,80 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id:http://devicetree.org/schemas/net/microchip,lan865x.yaml# >> +$schema:http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers >> + >> +maintainers: >> + - Parthiban Veerasooran<parthiban.veerasooran@xxxxxxxxxxxxx> >> + >> +description: >> + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet >> + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller >> + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible >> + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver >> + integrated into the LAN8650/1. The communication between the Host and >> + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial >> + Interface (TC6). >> + >> +allOf: >> + - $ref: ethernet-controller.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - const: microchip,lan8650 >> + - const: microchip,lan8651 > The order here is wrong, lan8561 needs to come before the fallback of > lan8650. Reply to this comment is in another email. > >> + - enum: >> + - microchip,lan8650 >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + description: >> + Interrupt from MAC-PHY asserted in the event of Receive Chunks >> + Available, Transmit Chunk Credits Available and Extended Status >> + Event. >> + maxItems: 1 >> + >> + spi-max-frequency: >> + minimum: 15000000 >> + maximum: 25000000 > You're missing a reference to spi-peripheral-props where this property > is defined. OK, I will add the below line in the above "allOf" section. - $ref: /schemas/spi/spi-peripheral-props.yaml# Best regards, Parthiban V > > Thanks, > Conor.
