RE: Cover-cover letter for two resctrl patch sets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>> Could you please instead send the two series separately
>> and note the dependency in the cover letter?
>
> FWIW, we're including ability to auto-retrieve and auto-apply dependencies
> with b4. It already works with preprequisite-patch-id trailers (as documented
> by git-format-patch), but we'll also add prerequisite-change-id in the near
> future as well.

Other interesting interactions with b4 in these patches:

1) Because of significant rebase changes, I dropped all the Reviewed/Tested tags
from v15. But b4 seems to have noticed that part 5/8 wasn't changed at all since
v14, and picked up some (but not all) of the tags for that patch:

  ✓ [PATCH v15 5/8] x86/resctrl: Add node-scope to the options for feature scope
    + Reviewed-by: Peter Newman <peternewman@xxxxxxxxxx> (✗ DKIM/google.com)
    + Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> (✓ DKIM/intel.com)
    + Reviewed-by: Babu Moger <babu.moger@xxxxxxx> (✓ DKIM/amd.com)

2) My cover-cover letter created some linkage between the two patch series.
Trying to retrieve the 2-part v4 series with "git am" would pick up the 8-part
v15. Using an explicit "-v4" does work to pick up just the 2-part patch.
  $ b4 am -v4 20240228112952.8090-tony.luck@xxxxxxxxx

3) That b4 am picks up Reinette's "if you make these changes" Reviewed by from:
  https://lore.kernel.org/all/12766261-26b2-4aa4-a735-c2380c4963fd@xxxxxxxxx/
[though I can see why it did and realize that we'll need "b4GPT" to parse
surrounding text to figure out that it should skip that].

Should folks that offer a conditional tag mark that in the text somewhere to
let b4 know not to auto-pick?

-Tony




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux