Re: [RFC PATCH net-next 7/9] ethtool: cmis_cdb: Add a layer for supporting CDB commands

[Simon Horman <horms@xxxxxxxxxx>]

On Mon, Jan 22, 2024 at 02:35:59PM +0000, Danielle Ratson wrote:

...

> Hi Simon,
> 
> Thanks for the feedback.
> 
> Ill fix that, something like:
> 
> diff --git a/net/ethtool/cmis_cdb.c b/net/ethtool/cmis_cdb.c
> index b27e12871816..888b02e6eade 100644
> --- a/net/ethtool/cmis_cdb.c
> +++ b/net/ethtool/cmis_cdb.c
> @@ -521,7 +521,7 @@ int ethtool_cmis_cdb_execute_cmd(struct net_device *dev,
>         }
> 
>         err = ethtool_cmis_page_init(&page_data, ETHTOOL_CMIS_CDB_CMD_PAGE, 0,
> -                                    ETHTOOL_CMIS_CDB_LPL_MAX_PL_LENGTH);
> +                                    sizeof(args->req.body));
>         if (err < 0)
>                 return err;

Thanks Danielle,

I also think something like that should fix the problem.