Hi, Miguel, On Tue, Jan 16, 2024 at 12:08 AM Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> wrote: > > On Mon, Jan 15, 2024 at 4:23 AM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote: > > > > Thank you for your suggestion, but since this will be replaced by the > > built-in target soon, and I don't want to change the tag to make Linus > > unhappy. Let's leave it as is. > > The issue is not a big deal and I appreciate that you made the effort > to enable Rust for your architecture. However, please note that we do > our best to maintain a clean formatting state for Rust code (i.e. > `rustfmt` should be run) and that people may see this in tests/CIs > that use the Make target. > > I don't think Linus would mind too much, and you could point him to > this email if you want (or you could put the fix on top); but if you > really want to keep the tag as-is, then we should consider it as a fix > for this cycle, i.e. we should not wait for e.g. the next cycle for > the built-in target. Could you please send it through your tree as > soon as possible? OK, since Linus said the merge window is paused now, I rebase and retag my tree and the Rust commit is like this, I think this is perfect now? https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-next&id=706f9e1ab7c7a58d80ef2c87d8720131253a2256 Huacai > > Cheers, > Miguel
