Hi Tony,
I'm just adding a few minor comments to the bigger items already
mentioned ...
On 12/7/2023 11:56 AM, Tony Luck wrote:
...
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 66942d7fba7f..1feb3b2e64fa 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -129,6 +129,7 @@ enum membw_throttle_mode {
> * @throttle_mode: Bandwidth throttling mode when threads request
> * different memory bandwidths
> * @mba_sc: True if MBA software controller(mba_sc) is enabled
> + * @mba_mbps_event: Event (local or total) for mba_sc
This is quite cryptic and does not add more than the variable name and type.
One example could be:
"Monitoring event guiding feedback loop when @mba_sc is true."
Please feel free to improve.
...
> @@ -3780,16 +3806,27 @@ static int rdtgroup_rename(struct kernfs_node *kn,
> return ret;
> }
>
> +static char *mba_sc_event_opt_name(struct rdt_resource *r)
This can be "const char *".
Reinette
