On Tue, 5 Dec 2023 19:01:47 +0100
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:
> Le 04/12/2023 à 23:16, Köry Maincent a écrit :
> > Thanks for your review!
> >
> > On Sun, 3 Dec 2023 22:11:46 +0100
> > Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:
> >
> >>> +
> >>> + fwl = firmware_upload_register(THIS_MODULE, dev, dev_name(dev),
> >>> + &pd692x0_fw_ops, priv);
> >>> + if (IS_ERR(fwl)) {
> >>> + dev_err(dev, "Failed to register to the Firmware Upload
> >>> API\n");
> >>> + ret = PTR_ERR(fwl);
> >>> + return ret;
> >>
> >> Nit: return dev_err_probe()?
> >
> > No EPROBE_DEFER error can be catch from firmware_upload_register()
> > function, so it's not needed.
>
> Hi,
>
> up to you to take it or not, but dev_err_probe() also logs the error
> code in a human readable way and it saves a few lines of code.
>
> If I remember correctly, it also saves some bytes in the .o file.
Oh, didn't know that.
> Other than that, it is a matter of style.
After some thought it seems indeed better, I will move on to dev_err_probe() in
next version.
Thanks,
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
