Thanks for your review!
On Sun, 3 Dec 2023 22:11:46 +0100
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:
> > +
> > + fwl = firmware_upload_register(THIS_MODULE, dev, dev_name(dev),
> > + &pd692x0_fw_ops, priv);
> > + if (IS_ERR(fwl)) {
> > + dev_err(dev, "Failed to register to the Firmware Upload
> > API\n");
> > + ret = PTR_ERR(fwl);
> > + return ret;
>
> Nit: return dev_err_probe()?
No EPROBE_DEFER error can be catch from firmware_upload_register() function, so
it's not needed.
Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
